55366[FEATURE] Add RemoveRecordUriViewHelper in sysext:backend
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 1522
-
Reiner Teubner uploaded patch set 1 01/15/18, 16:52
-
TYPO3com voted on patch set 1 V -1 01/15/18, 16:52 Completed build in 08s on Mon, 15 Jan, 05:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18343
-
Reiner Teubner uploaded patch set 2 01/15/18, 16:54
-
TYPO3com voted on patch set 2 V +1 01/15/18, 17:00 Completed build in 06m 23s on Mon, 15 Jan, 06:00 PM Test Summary: 30055 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18344
-
Wouter Wolters commented on patch set 2 01/15/18, 17:26
-
Reiner Teubner voted on patch set 2 V -1 01/15/18, 17:38
-
Georg Ringer commented on patch set 2 01/16/18, 08:25
Feature-83574-FEATUREAddRemoveRecordViewHelperInSysextbackend.rst:4Unresolvedthe [FEATURE] is not needed hereFeature-83574-FEATUREAddRemoveRecordViewHelperInSysextbackend.rst:14Unresolvedplease add an example -
Andreas Kienast commented on patch set 2 01/16/18, 11:47
RemoveRecordViewHelper.php:36UnresolvedHm, the ViewHelper generates a HTML tag. Isn't using the `AbstractTagBasedViewHelper` a better choice here? -
Reiner Teubner rebased onto patch set 3 01/16/18, 13:06
-
TYPO3com voted on patch set 3 V +1 01/16/18, 13:18 Completed build in 11m 53s on Tue, 16 Jan, 02:18 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18358
-
Reiner Teubner uploaded patch set 4 01/16/18, 13:25
-
Reiner Teubner uploaded patch set 5 01/16/18, 13:28
-
TYPO3com voted on patch set 4 V +1 01/16/18, 13:32 Completed build in 07m 21s on Tue, 16 Jan, 02:32 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18366
-
Reiner Teubner uploaded patch set 6 01/16/18, 13:35
-
TYPO3com voted on patch set 5 V +1 01/16/18, 13:38 Completed build in 10m 03s on Tue, 16 Jan, 02:38 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18367
-
TYPO3com voted on patch set 6 V +1 01/16/18, 13:42 Completed build in 06m 59s on Tue, 16 Jan, 02:42 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18369
-
Jörg Bösche voted on patch set 6 CR +1 01/16/18, 13:50
-
Reiner Teubner rebased onto patch set 7 01/16/18, 14:01
-
TYPO3com voted on patch set 7 V +1 01/16/18, 14:11 Completed build in 09m 58s on Tue, 16 Jan, 03:11 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18372
-
Reiner Teubner commented on patch set 7 01/17/18, 08:36
Reduce the VH to just return a uri (html stuff removed). Add an example and remove [Feature] in rst file. -
Christian Kuhn commented on patch set 7 CR -1 01/17/18, 13:17
can imho be solved with ModuleLinkViewHelper already. -
Reiner Teubner abandoned the change 01/17/18, 16:57
Concept does not work out. We go back to the drawing board.
RemoveRecordViewHelper.php:1Unresolved