Review main Merged

55381[TASK] impexp: Remove 'max number of records' restriction

Christian Kuhn CR +2 V +2 Normal +91 −36 updated 01/17/18, 12:49

Commit message

The 'export' module has a restriction to limit the number
of exported records. The patch removes this from the
interface:
* The default limit is arbitrary, removing that limit
  declutters the interface a little bit
* Users probably always did just set this to some number
  high enough to export everything they wanted
* It was not clear what exactly is counted. At least it
  was not the total number of exported records ...
* The error and flash messages were unclear and sometimes
  not shown at all
* The limit could lead to data integrity issues in the
  export file, for example if a page links to some other
  page that is not exported
* Presets that increased the limit still work
* To prevent a breaking patch, the affected PHP method
  arguments deprecate some arguments instead of fully
  removing them in v9

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6