Review main Merged

55382[TASK] impexp: Remove "Max file size" restriction

Christian Kuhn CR +2 V +2 Normal +50 −19 updated 01/17/18, 15:36

Commit message

The export modules has a file size restriction
that skips file exports if they are bigger than
by default 1MB. This can be raised with an input
field.
The patch removes that input field:
* Configured maximum file sizes are checked during
  upload already. A well configured system should
  expect existing files are ok and just export everything
* The 1MB default size is old fashioned. Typical images
  are often bigger in size and resized only during FE
  rendering
* Skipping arbitrary files in export has a negative
  impact on data consistency of the export.
* Single files can still be excluded from export if
  needed
* Users up until now usually had manually raised the
  limit to some value high enough to make all files fit

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7