Review main Merged

55479[BUGFIX] NewContentElementWizardController to NewContentElementController

Oliver Hader CR +2 V +2 Hard +61 −619 updated 01/29/18, 20:50

Commit message

NewContentElementWizardController, which has been introduced for TYPO3 v9
to render the new content element process in a dedicated modal was just a
duplicate of the existing NewContentElementController class with some
minor adjustments and code flow enhancements (names, empty checks).

However, there have been several side effects like:
* hook implementing NewContentElementWizardHookInterface would have been
  called by both object instances, having different public properties -
  the most common access to $parentObject->id or ~->sys_language would
  have failed to to property visibility and change names
* the JavaScript closure callback to adjust the URL when interacting in
  the browser was hard-coded to modal rendering, with still having the
  possibility to render the old behavior e.g. in the web>list view

To overcome these flaws both mentioned classes have been merged since the
functionality was not that much different anyway. Besides that different
JavaScript client scopes ('window' or 'list_frame') are forwarded to the
according object instances.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5