Review TYPO3_8-7 Merged

55554[BUGFIX] Re-apply colorspace to resulting image

Christian Kuhn CR +2 V +2 Easy +2 −0 updated 02/04/18, 19:22

Commit message

When using filters the colorspace is not always applied.
A quickfix is to add the colorspace-setting again before
writing the output-image.
Multiple colorspace-settings on the commandline will be
executed in order. For example the grayscale-filter uses
"-colorspace GRAY". The final output-image can then be
converted to "-colorspace sRGB" again so the brightness
appears correct (not too dark) again.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 02/04/18, 18:42

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/04/18, 18:56 Completed build in 14m 13s on Sun, 4 Feb, 07:56 PM Test Summary: 57911 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1727

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 02/04/18, 19:22

  4. Christian Kuhn merged patch set 2 02/04/18, 19:22