Review main Merged

55556[BUGFIX] Do not check HTTP referrer anymore

Markus Klein CR +2 V +2 Hard +176 −185 updated 02/19/18, 20:47

Commit message

Under certain circumstances some browsers do not set the HTTP referrer
anymore due to privacy reasons. Hence, checking the referrer breaks
functionality.

The configuration option [SYS][doNotCheckReferer] is also removed as
it is not needed anymore.

Review

  • Code review CR +2
    • Susi Moog +2
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2
    • Susi Moog +2
    • Markus Klein +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1922

  1. Markus Klein uploaded patch set 1 02/04/18, 21:14

  2. TYPO3com voted on patch set 1 V +1 02/04/18, 21:20 Completed build in 06m 34s on Sun, 4 Feb, 10:20 PM Test Summary: 30390 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18908

  3. Georg Ringer commented on patch set 1 02/05/18, 07:58

    this deserves a breaking RST as it removes a setting which can be used as by 3rd party extensions
  4. Michael Schams uploaded patch set 2 02/05/18, 10:08

  5. TYPO3com voted on patch set 2 V +1 02/05/18, 10:13 Completed build in 05m 35s on Mon, 5 Feb, 11:13 AM Test Summary: 30392 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18918

  6. Benni Mack voted on patch set 2 CR +1 02/05/18, 10:32

  7. Tobi Kretschmann voted on patch set 2 CR +1 02/05/18, 10:35

  8. Jörg Bösche voted on patch set 2 CR +1 02/05/18, 10:36

  9. Michael Schams commented on patch set 2 V +1 02/05/18, 10:49

    Successfully tested patch set 1 and added breaking RST as the only change in patch set 2.
  10. Markus Klein commented on patch set 2 V -1 CR -1 02/05/18, 11:54

    1.) I disagree about the breaking change: - it would prevent us from rolling this out to lower branches - using the now undefined setting results in bool false, hence it works like before 2.) IF we add an rst we need the [!!!] in the commit msg
  11. Mathias Schreiber commented on patch set 2 02/05/18, 12:07

    could users run into PHP warning due to a non existent array key here?
  12. Susi Moog commented on patch set 2 02/05/18, 12:07

    > Patch Set 2: Verified-1 Code-Review-1 > 2.) IF we add an rst we need the [!!!] in the commit msg I'd disagree about breaking but agree with the rst file. As we know there are extensions checking the setting, we should give them a chance to see that their check isn't necessary anymore - so I'd go for: add an important rst, no breaking.
  13. Benni Mack commented on patch set 2 02/05/18, 12:19

    basically - drop the option in master and have it disabled by default ("enable the option") in v8 and v7 as Important change?
  14. Susi Moog commented on patch set 2 02/05/18, 12:38

    > Patch Set 2: > > basically - drop the option in master and have it disabled by default ("enable the option") in v8 and v7 as Important change? yes, with the corresponding extScanner update - as it's a global option that should be something we can automatically find.
  15. Markus Klein commented on patch set 2 02/05/18, 14:08

    Suggestion: I create a dedicated patch for v8 and v7, which simply sets the default to true of that option.
  16. Benni Mack uploaded patch set 3 02/09/18, 12:59

  17. Benni Mack voted on patch set 3 V +1 CR +1 02/09/18, 13:00

  18. TYPO3com voted on patch set 3 V +1 02/09/18, 13:08 Completed build in 08m 40s on Fri, 9 Feb, 02:08 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19185

  19. Markus Klein commented on patch set 3 V +1 CR +1 02/09/18, 15:42

    Since Michael high-jacked my authorship with set 2 ;-), I take the honor to vote on my own patch.
  20. Susi Moog voted on patch set 3 V +2 CR +2 02/09/18, 18:14

  21. Susi Moog merged patch set 4 02/09/18, 18:14

  22. Stephan Großberndt commented on patch set 4 02/19/18, 20:47

    Backports to 8.7 and 7.6 missing