55556[BUGFIX] Do not check HTTP referrer anymore
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Markus Klein +1
- Benni Mack +1
-
Verified V +2
- Susi Moog +2
- Markus Klein +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Classes/Controller/File/FileController.php+2 −9
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+114 −131
- typo3/sysext/backend/Classes/Controller/SimpleDataHandlerController.php+12 −19
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+0 −6
- typo3/sysext/core/Configuration/DefaultConfiguration.php+0 −1
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+0 −3
- typo3/sysext/core/Documentation/Changelog/master/Important-83768-RemoveReferrerCheck.rstnew+40 −0
- typo3/sysext/impexp/Classes/Controller/ImportExportController.php+5 −15
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+3 −1
Review log 1922
-
Markus Klein uploaded patch set 1 02/04/18, 21:14
-
TYPO3com voted on patch set 1 V +1 02/04/18, 21:20 Completed build in 06m 34s on Sun, 4 Feb, 10:20 PM Test Summary: 30390 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18908
-
Georg Ringer commented on patch set 1 02/05/18, 07:58
this deserves a breaking RST as it removes a setting which can be used as by 3rd party extensions -
Michael Schams uploaded patch set 2 02/05/18, 10:08
-
TYPO3com voted on patch set 2 V +1 02/05/18, 10:13 Completed build in 05m 35s on Mon, 5 Feb, 11:13 AM Test Summary: 30392 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18918
-
Benni Mack voted on patch set 2 CR +1 02/05/18, 10:32
-
Tobi Kretschmann voted on patch set 2 CR +1 02/05/18, 10:35
-
Jörg Bösche voted on patch set 2 CR +1 02/05/18, 10:36
-
Michael Schams commented on patch set 2 V +1 02/05/18, 10:49
Successfully tested patch set 1 and added breaking RST as the only change in patch set 2. -
Markus Klein commented on patch set 2 V -1 CR -1 02/05/18, 11:54
1.) I disagree about the breaking change: - it would prevent us from rolling this out to lower branches - using the now undefined setting results in bool false, hence it works like before 2.) IF we add an rst we need the [!!!] in the commit msg -
Mathias Schreiber commented on patch set 2 02/05/18, 12:07
could users run into PHP warning due to a non existent array key here? -
Susi Moog commented on patch set 2 02/05/18, 12:07
> Patch Set 2: Verified-1 Code-Review-1 > 2.) IF we add an rst we need the [!!!] in the commit msg I'd disagree about breaking but agree with the rst file. As we know there are extensions checking the setting, we should give them a chance to see that their check isn't necessary anymore - so I'd go for: add an important rst, no breaking. -
Benni Mack commented on patch set 2 02/05/18, 12:19
basically - drop the option in master and have it disabled by default ("enable the option") in v8 and v7 as Important change? -
Susi Moog commented on patch set 2 02/05/18, 12:38
> Patch Set 2: > > basically - drop the option in master and have it disabled by default ("enable the option") in v8 and v7 as Important change? yes, with the corresponding extScanner update - as it's a global option that should be something we can automatically find. -
Markus Klein commented on patch set 2 02/05/18, 14:08
Suggestion: I create a dedicated patch for v8 and v7, which simply sets the default to true of that option. -
Benni Mack uploaded patch set 3 02/09/18, 12:59
-
Benni Mack voted on patch set 3 V +1 CR +1 02/09/18, 13:00
-
TYPO3com voted on patch set 3 V +1 02/09/18, 13:08 Completed build in 08m 40s on Fri, 9 Feb, 02:08 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19185
-
Markus Klein commented on patch set 3 V +1 CR +1 02/09/18, 15:42
Since Michael high-jacked my authorship with set 2 ;-), I take the honor to vote on my own patch. -
Susi Moog voted on patch set 3 V +2 CR +2 02/09/18, 18:14
-
Susi Moog merged patch set 4 02/09/18, 18:14
-
Stephan Großberndt commented on patch set 4 02/19/18, 20:47
Backports to 8.7 and 7.6 missing