Review TYPO3_8-7 Merged

55558[BUGFIX] Prevent enforcing opened database connection with initCommands

Helmut Hummel CR +2 V +2 Normal +70 −11 updated 02/06/18, 10:01

Commit message

This patch moves the execution of configured initCommands to the end
of connect function. This prevents a database connection from being
opened by default due to the execution of commands right after class
initialization and still ensures a connection is configured properly
before first command execution.

Furthermore this patch adds a new functional test for the ErrorHandler.
The test uses some predefined initCommands to enforce UTF8 support to be
set. This isn't necessary but uses initCommands in a safe way. Due to
the predefined initCommands the test failed before as the connection was
forced to be opened. For further information see the referenced forge
ticket.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2