Review main Abandoned

55579[WIP][TASK] Add FieldInformation to inline control container

Christian Kuhn CR 0 V 0 Easy +5 −0 updated 07/02/18, 12:41

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 02/06/18, 14:35

  2. TYPO3com voted on patch set 1 V +1 02/06/18, 14:43 Completed build in 07m 44s on Tue, 6 Feb, 03:43 PM Test Summary: 30440 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19017

  3. Christian Kuhn commented on patch set 1 CR -2 02/06/18, 15:35

    that should do. the register syntax in 'ctrl' is contrary to other wizards for fields though. it has been done like that to allow wizards on containers which have no field (like OuterWrap) ... but inline is hybrid: it's technically an render container, but it also has a single field config in TCA, so people expect wizards can be configured on 'columns' level ... would be possible to merge that, but also inline has 2 (!) container, and columns config should then hit on ControlContainer only ...
  4. Christian Kuhn abandoned the change 07/02/18, 12:41

    abandoning: will be fixed with https://review.typo3.org/#/c/57397/