Review main Merged

55593[BUGFIX] Remove wrong phpDoc for defineTypo3RequestTypes function

Wouter Wolters CR +2 V +2 Easy +1 −2 updated 02/07/18, 21:21

Commit message

There is no return value, drop the @return tag.
Also add @param int $requestType to setRequestType

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Schreiber +1
  • Verified V +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Wouter Wolters uploaded patch set 1 02/07/18, 20:39

  2. Mathias Schreiber voted on patch set 1 V +1 CR +1 02/07/18, 20:40

  3. Wouter Wolters uploaded patch set 2 02/07/18, 20:42

  4. Mathias Schreiber voted on patch set 2 V +1 CR +1 02/07/18, 20:42

  5. TYPO3com voted on patch set 2 V +1 02/07/18, 20:49 Completed build in 07m 41s on Wed, 7 Feb, 09:49 PM Test Summary: 30461 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19100

  6. TYPO3com voted on patch set 1 V +1 02/07/18, 20:50 Completed build in 10m 56s on Wed, 7 Feb, 09:50 PM Test Summary: 30461 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19099

  7. Benni Mack voted on patch set 2 V +2 CR +2 02/07/18, 21:21

  8. Benni Mack merged patch set 3 02/07/18, 21:21