Review main Abandoned

55720[TASK] Optimize ArrayUtility::sortArrayWithIntegerKeys

Mathias Schreiber CR 0 V 0 Easy +10 −4 updated 02/14/18, 21:46

Commit message

The method used an unnecessary array_keys() which has been replaced
by its C equivalent ARRAY_FILTER_USE_KEY.
Furthermore is now uses MathUtility::canBeInterpretedAsInteger which
got an early guard clause to circumvent unnecessary checks, since its intention
is to be called with integer values in the first place.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 34

  1. Mathias Schreiber uploaded patch set 1 02/14/18, 19:38

  2. TYPO3com voted on patch set 1 V +1 02/14/18, 19:46 Completed build in 08m 39s on Wed, 14 Feb, 08:46 PM Test Summary: 30771 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19592

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 02/14/18, 21:35

  4. Mathias Schreiber abandoned the change 02/14/18, 21:46

    POC abandoned for the time being. If PHP12 freaks out, I'll remember and pull this one from my hat