55735[TASK] Remove ClickMenuOnIconViewHelper of filelist extension
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Mathias Schreiber +1
- Tymoteusz Motylewski +1
- Andreas Kienast +1
-
Verified V +2
- Christian Kuhn +2
- Mathias Schreiber +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1216
-
Georg Ringer uploaded patch set 1 02/15/18, 13:01
-
TYPO3com voted on patch set 1 V -1 02/15/18, 13:09 Completed build in 07m 33s on Thu, 15 Feb, 02:09 PM Test Summary: 4 of 30983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19650
-
Benni Mack rebased onto patch set 2 02/15/18, 16:03
-
TYPO3com voted on patch set 2 V -1 02/15/18, 16:17 Completed build in 13m 42s on Thu, 15 Feb, 05:17 PM Test Summary: 2 of 30983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19659
-
TYPO3com voted on patch set 2 V +1 02/15/18, 18:51 Completed build in 3h 01m 05s on Thu, 15 Feb, 07:51 PM Test Summary: 30825 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19659
-
Andreas Kienast commented on patch set 2 CR -1 02/15/18, 19:20
fl:link.clickMenuOnIcon is used in a lot of fixtures for unit tests. -
Andreas Kienast commented on patch set 2 V +1 CR +1 02/15/18, 19:21
It seems the fixtures are not used anymore. -
Wouter Wolters voted on patch set 2 CR +1 02/15/18, 19:45
-
Benni Mack commented on patch set 3 02/15/18, 20:46
Published edit on patch set 2. -
Andreas Kienast voted on patch set 3 V +1 CR +1 02/15/18, 20:49
-
TYPO3com voted on patch set 3 V +1 02/15/18, 20:55 Completed build in 08m 23s on Thu, 15 Feb, 09:55 PM Test Summary: 30825 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19683
-
Tymoteusz Motylewski voted on patch set 3 CR +1 02/16/18, 12:06
-
Mathias Schreiber voted on patch set 3 V +1 CR +1 02/16/18, 15:08
-
Christian Kuhn voted on patch set 3 V +2 CR +2 02/16/18, 16:29
-
Christian Kuhn merged patch set 4 02/16/18, 16:29
-
Christian Kuhn commented on patch set 4 02/16/18, 16:30
nice!