Review main Merged

55753[TASK] Move FE User initialization into PSR-15 middleware

Benni Mack CR +2 V +2 Normal +116 −5 updated 02/19/18, 09:05

Commit message

The initialization of a frontend user is currently bound to TSFE,
however, the only parts where TSFE is actually needed is to
set the frontenduserauthentication object to $TSFE->fe_user
and to call a post-processing hook, which could be dealt with
through a middleware for extensions.

Further steps are to deprecate "initFEuser()" method, and to move
the transferring of the user session into the FrontendUser object
itself, once this is not using superglobals instead anymore.

Additional cleanups on the Authentication object will follow separately
once all Middlewares and the Request object are in place.

For now, this patch aims to extract the logic and keep maximum backwards-
compatibility.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3