Review main Abandoned

55777[TASK] Inject the PackageManager into the DependencyResolver

Benjamin Franzke CR 0 V 0 Easy +12 −3 updated 03/01/18, 19:27

Commit message

We do not use GeneralUtility::makeInstance here as that is
a dependency injection anti pattern (called service locator patten)
which is discouraged by PSR-11 (1,3 "Recommended Usage").
Furthermore using dependency injection makes really
clear (opposed to makeInstance) that the injected PackageManager
might also be a derived class (e.g. FailsafePackageManager).

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2