Review main Merged

55795[TASK] Remove unused Bootstrap dependency from frontend request handler

Benjamin Franzke CR +2 V +2 Easy +1 −19 updated 02/19/18, 20:31

Commit message

Due to moving BE user authentication to a middleware, the Bootstrap
instance is no longer needed in the frontend request handler.

As the backend request handler is free of a Bootstrap dependency as well,
we can also remove the Bootstrap injection in Http\AbstractApplication.

The installer and legacy request handlers are unaffected:
 * The installer application instantiates the request handler on its own.
 * Legacy request handlers are dispatched by the legacy request handler
   middleware which keeps passing in a Bootstrap instance

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2