Review main Merged

55802[TASK] Consolidate singleton retrieval

Benjamin Franzke CR +2 V +2 Easy +29 −16 updated 02/27/18, 10:24

Commit message

There is Bootstrap::getInstance()->getEarlyInstance() and
GeneralUtility::makeInstance() to retrieve (global) early instances.
Sometimes the former, sometimes the latter is used (e.g. to
retrieve the PackageManager).

Classes should not know whether something is an early
instance or not. Implementation details like that should be
abstracted into a singleton container. That (currently) is
GeneralUtility::makeInstance().

As there is no obvious reason why different methods are used,
we now use GenerallyUtility::makeInstance() to retrieve singletons.

Add all early singleton instances to the GeneralUtility singleton array
and stop using Bootstrap::getEarlyInstance in classes outside Bootstrap.

One exception to this is the composer ClassLoader. That (obviously)
does not implement the TYPO3 SingletonInterface.
We now push that instance to ClassLoadingInformation during the
bootstrap. (similar to how the PackageManager is pushed to the
ExtensionManagementUtility).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5