Review main Merged

55823[BUGFIX] Notice free TcaSelectItems testing

Christian Kuhn CR +2 V +2 Hard +160 −261 updated 02/20/18, 13:15

Commit message

Making FormEngine data providers notice free is a mixture of
fixing notices in the test subject, and improving test setup:
* It is assumed that stuff like BE_USER and LANG object exists,
  $subject access to these globals which throw notices is not
  fixed, instead the test setup is changed to mock these where
  needed.
* Data provider which have dependencies to other data prodivers
  assume their data is properly set, too. In those cases the
  test setup porperly sets this dependent data.
* Various other "real" notice fixes in test subject and code
  called by the test subject is actually fixed.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7