Review main Merged

55829[TASK] Streamline deprecation handling in icon API

Oliver Hader CR +2 V +2 Easy +21 −7 updated 02/20/18, 22:17

Commit message

Icon API supports some basic handling of deprecated icons
as well as keeping track of replacements. However, it is
not possible to automatically benefit from these
replacements in case they are defined.

This change tackles the following:

* bug when logging deprecated icon identifiers due to
  mismatching sprintf arguments
* automatically making use of available replacements
  instead of throwing exception
* possibility to retrieve deprecated icons and
  replacements (in order to render them in ext:styleguide)

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2