Review main Merged

55852[BUGFIX] Fix wrong type in "rootLevel" option

Armin Vieweg CR +2 V +2 Easy +10 −10 updated 02/21/18, 11:36

Commit message

Several system tables used a wrong type for ctrl option "rootLevel"
in TCA. By definition in TCAref "rootLevel" is from type integer.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2
    • Georg Ringer +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 67

  1. Armin Vieweg uploaded patch set 1 02/21/18, 09:53

  2. TYPO3com voted on patch set 1 V +1 02/21/18, 10:01 Completed build in 08m 27s on Wed, 21 Feb, 11:01 AM Test Summary: 30905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19964

  3. Oliver Klee voted on patch set 1 CR +1 02/21/18, 10:58

  4. Oliver Klee commented on patch set 1 02/21/18, 10:58

    Also 8.7 and 7.6?
  5. Christian Kuhn commented on patch set 1 V +1 CR +1 02/21/18, 11:22

    Reply

    i'd rather keep master only that for this mostly cosmetically change.
  6. Georg Ringer voted on patch set 1 V +2 CR +2 02/21/18, 11:35

  7. Georg Ringer merged patch set 2 02/21/18, 11:36