Review main Merged

55866[TASK] Consolidate hooks in workspace preview

Benni Mack CR +2 V +2 Easy +7 −25 updated 02/23/18, 11:22

Commit message

The Workspace preview hooks first hook into TSFE->connectToDB
to see if ADMCMD_prev is set via GP/cookie. If so, the TSFE object gets
re-instantiated, which is utterly unnecessary.

Additionally, it unsets the BE user cookie, solely to use a SECOND hook
(initializePreviewUser()) to check if the BE_USER is null.

Instead, the hooks are consolidated and the one hook after a regular BE user
exists, gets used, and overridden by a custom BE user object as defined
in the preview configuration with the workspace preview.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2