Review main Merged

55913[TASK] Move preview setting evaluation in separate method

Benni Mack CR +2 V +2 Normal +70 −54 updated 07/05/19, 16:20

Commit message

The TSFE method "determineId" is hard to read, mostly due to
the fact that it first evaluates preview settings from admin panel
or logged-in backend users, and then calls "fetch_the_id()" possibly
multiple times.

In order to increase readability, the preview settings evaluation
is moved into a custom protected method within TSFE.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1