Review main Merged

55988[TASK] Do not reinitialize cache and package manager in clearAllCache

Benjamin Franzke CR +2 V +2 Easy +0 −5 updated 03/05/18, 13:39

Commit message

Those (re)initializations originate from https://review.typo3.org/19605
were reinitializeClassLoaderAndCachesAndPackageManagement()
was used to "Reinitialize the class loader during clear cache actions"
(according to phpdoc).

Then with the changes in https://review.typo3.org/29811
reinitializeClassLoaderAndCachesAndPackageManagement()
was dropped and splitted into unregisterClassLoader(),
flagCachingFrameworkForReinitialization().
initializeCachingFramework() and initializePackageManagement().
(just historical info, still all good)

Then http://review.typo3.org/39827 came and dropped unregisterClassLoader
but left the CacheManager and PackageManager reinitialization in place
superfluously. It's superfluous as the original usecase was to
reinitialize the class loader which is no longer required.

Note: InstallTool uses the FailsafePackageManager, although it's called
failsafe it still loads _all_ packages defined in PackageStates.php
into $GLOBALS['TYPO3_LOADED_EXT'] and therefore there is no requirement
for a new PackageManager instance to load ext_localconf.php from all
active extensions.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1