Review main Abandoned

56028[FEATURE] Refactor form configuration handling

Ralf Zimmermann CR 0 V 0 Nightmare +1957 −1077 updated 04/25/18, 19:21

Commit message

* Support for "imports" within YAML setup files

* Refactor code for YAML loading / writing

  To align with the core YAML file loader the YAML file loader of the
  form framework now supports the "imports" instruction.
  On top, YAML file loading from FAL resources are possible
  (like before) but "imports" are restricted to EXT:... paths.

  EXT:form setup files are now registered via
  '<module|plugin>.tx_form.settings.configurationFile'.
  This single configuration file can contain multiple "imports"
  instructions.
  The current configuration file
  'EXT:form/Configuration/Yaml/FormSetup.yaml' just imports the 3 well
  known EXT:form setup files (BaseSetup.yaml, FormEditorSetup.yaml,
  FormEngineSetup.yaml). This seems pointless, but we plan to split
  the setup files into atoms (e.g. MultiCheckbox.yaml) which can be
  imported or can be omitted if needed.
  This will be done in a separate patch to reduce the complexity of
  this patchset.

* Refactor configuration manager and persistence manager code to ensure
  proper exception handling

  The YAML file loader / writer handle resources from FAL.
  Since FAl throws some top level exceptions, the YAML file
  loader / writer and the persistence manager now catch all possible
  exceptions and transform them into own exceptions which can be handled
  by parent consumers.

* Add more unit tests

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 46

Show 26 more files