Review main Merged

56075[TASK] Remove duplicate IconFactory instantiation

Ralf Zimmermann CR +2 V +2 Easy +0 −1 updated 03/09/18, 12:58

Commit message

Remove duplicate IconFactory instantiation within PageLayoutView

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
    • Björn Jacob +1
    • Wouter Wolters +1
    • Mathias Brodala +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Ralf Zimmermann uploaded patch set 1 03/09/18, 12:00

  2. Mathias Brodala voted on patch set 1 CR +1 03/09/18, 12:00

  3. TYPO3com voted on patch set 1 V +1 03/09/18, 12:08 Completed build in 08m 25s on Fri, 9 Mar, 01:08 PM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20740

  4. Wouter Wolters voted on patch set 1 V +1 CR +1 03/09/18, 12:09

  5. Oliver Klee voted on patch set 1 CR +1 03/09/18, 12:11

  6. Oliver Klee commented on patch set 1 03/09/18, 12:12

    Are 8.7 and 7.6 not affected?
  7. Ralf Zimmermann commented on patch set 1 03/09/18, 12:13

    Reply

    I did not find the doubling in the 8.7 branch
  8. Björn Jacob voted on patch set 1 CR +1 03/09/18, 12:20

  9. Christian Kuhn voted on patch set 1 V +2 CR +2 03/09/18, 12:58

  10. Christian Kuhn merged patch set 2 03/09/18, 12:58