Review main Merged

56196[TASK] Fail acceptance tests on JavaScript errors in browser console

Christian Kuhn CR +2 V +2 Easy +10 −13 updated 03/16/18, 21:33

Commit message

Raise typo3/testing-framework to 3.3.0

composer update typo3/testing-framework

Acceptance tests are configured to fail if JavaScript
errors are raised in the console.
See https://github.com/TYPO3/testing-framework/blob/master/Resources/Core/
Build/Configuration/Acceptance/Support/Helper/Acceptance.php

This commit also fixeds a bug found by the tests.
A requireJS error was thrown - timeout on loading `nprogress`
from within Loader.js.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3