Review TYPO3_8-7 Merged

56199[BUGFIX] Let textareas within finisher inspector properties work

Ralf Zimmermann CR +2 V +2 Easy +1 −1 updated 04/05/18, 07:27

Commit message

Exclude textareas from javascripts sortable logic within the finisher
inspectors (form editor) to make it editable.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
  • Verified V +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Ralf Zimmermann uploaded patch set 1 03/15/18, 21:52

  2. Ralf Zimmermann commented on patch set 1 03/15/18, 21:52

    This is already fixed for master by review:52007. For a quick test edit EXT:form/Configuration/Yaml/FormEditorSetup.yaml line 1144 and add 250: identifier: testEditor templateName: 'Inspector-TextareaEditor' label: 'Textarea test' propertyPath: 'options.dummy' Now open the form editor and add the "Email to sender" finisher. The textarea "Textarea test" must be editable.
  3. TYPO3com voted on patch set 1 V +1 03/15/18, 22:06 Completed build in 14m 20s on Thu, 15 Mar, 11:06 PM Test Summary: 58213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2123

  4. Wouter Wolters voted on patch set 1 V +1 CR +1 04/04/18, 18:21

  5. Andreas Kienast voted on patch set 1 CR +1 04/05/18, 07:24

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 04/05/18, 07:27

  7. Andreas Kienast merged patch set 2 04/05/18, 07:27