Review TYPO3_8-7 Merged

56428[BUGFIX] Allow PSR-7 Uris to allow no port at all

Georg Ringer CR +2 V +2 Easy +21 −8 updated 03/22/18, 14:59

Commit message

In order to set a PSR-7 based uri to the default port
the specs allow to set $uri->withPort(null) but our
tests and implementation restrict that.

Review

  • Code review CR +2
    • Georg Ringer +2
  • Verified V +2
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Georg Ringer commented on patch set 1 03/22/18, 12:51

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/22/18, 13:04 Completed build in 12m 48s on Thu, 22 Mar, 02:04 PM Test Summary: 58249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2171

  3. Georg Ringer voted on patch set 1 V +2 CR +2 03/22/18, 14:59

  4. Georg Ringer merged patch set 2 03/22/18, 14:59