Review main Abandoned

56584[FEATURE] Add IDs for content elements in debug mode to page and list module

Steffen Kamper CR 0 V 0 Easy +42 −2 updated 10/28/18, 10:38

Commit message

First add classes to the body tag, then apply css rules for debug mode.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 1319

  1. Steffen Kamper uploaded patch set 1 04/06/18, 13:10

  2. TYPO3com voted on patch set 1 V +1 04/06/18, 13:20 Completed build in 10m 21s on Fri, 6 Apr, 03:20 PM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22124

  3. Oliver Klee updated the commit message in patch set 2 04/06/18, 13:45

  4. TYPO3com voted on patch set 2 V +1 04/06/18, 13:55 Completed build in 09m 08s on Fri, 6 Apr, 03:55 PM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22127

  5. Joshua Westerheide commented on patch set 2 V +1 CR +1 04/06/18, 15:42

    Maybe disable the default tooltip then?
  6. Steffen Kamper commented on patch set 1 V +1 CR +1 04/06/18, 16:48

    looks good and works!
  7. Steffen Kamper commented on patch set 1 04/06/18, 16:51

    sry for my review - patch was from me and reply was for another one
  8. Daniel Goerz commented on patch set 2 CR -1 04/06/18, 17:25

    For a new Feature a short rst File is required that describes how to take advantage of it.

    ModuleTemplate.php:301

    The $context is currently not needed at all if I am not mssing something, isnt it? Also please use single quotes for the string. '<body class="' . $debug . '">'
  9. Steffen Kamper uploaded patch set 3 04/07/18, 10:37

  10. Steffen Kamper uploaded patch set 4 04/07/18, 10:38

  11. TYPO3com voted on patch set 3 V -1 04/07/18, 10:47 Completed build in 09m 28s on Sat, 7 Apr, 12:47 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22181

  12. TYPO3com voted on patch set 4 V -1 04/07/18, 10:48 Completed build in 09m 36s on Sat, 7 Apr, 12:48 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22182

  13. Oliver Klee commented on patch set 5 04/07/18, 11:10

    Published edit on patch set 4.
  14. TYPO3com voted on patch set 5 V -1 04/07/18, 11:19 Completed build in 08m 26s on Sat, 7 Apr, 01:19 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22183

  15. Daniel Goerz commented on patch set 5 04/07/18, 11:21

    ModuleTemplate.php:301

    Again, what do we need the $context for? The CSS only cares for the debug class.
  16. Mathias Schreiber commented on patch set 5 V -1 CR -1 04/08/18, 14:15

    _module_web_page.scss:391 Unresolved

    Can you use one of the available color variables here, please?

    _module_web_page.scss:396 Unresolved

    Please do not use any classes prefixed with t3js- for styling purposes. These are only to be used for JS triggers.
  17. Steffen Kamper uploaded patch set 6 04/09/18, 11:08

  18. TYPO3com voted on patch set 6 V -1 04/09/18, 11:16 Completed build in 07m 56s on Mon, 9 Apr, 01:16 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22219

  19. Benni Mack abandoned the change 10/28/18, 10:38

    abandoned for now, as there was no feedback in the last 6 months. Can be restored later.