56584[FEATURE] Add IDs for content elements in debug mode to page and list module
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 5
- Build/Resources/Public/Sass/typo3/_module_web_page.scss2+19 −0
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php2+5 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Feture-56584-AddIdsToContentElements.rstnew+16 −0
- typo3/sysext/install/Resources/Public/Css/install.css+1 −1
Review log 1319
-
Steffen Kamper uploaded patch set 1 04/06/18, 13:10
-
TYPO3com voted on patch set 1 V +1 04/06/18, 13:20 Completed build in 10m 21s on Fri, 6 Apr, 03:20 PM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22124
-
Oliver Klee updated the commit message in patch set 2 04/06/18, 13:45
-
TYPO3com voted on patch set 2 V +1 04/06/18, 13:55 Completed build in 09m 08s on Fri, 6 Apr, 03:55 PM Test Summary: 30924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22127
-
Joshua Westerheide commented on patch set 2 V +1 CR +1 04/06/18, 15:42
Maybe disable the default tooltip then? -
Steffen Kamper commented on patch set 1 V +1 CR +1 04/06/18, 16:48
looks good and works! -
Steffen Kamper commented on patch set 1 04/06/18, 16:51
sry for my review - patch was from me and reply was for another one -
Daniel Goerz commented on patch set 2 CR -1 04/06/18, 17:25
For a new Feature a short rst File is required that describes how to take advantage of it.ModuleTemplate.php:301The $context is currently not needed at all if I am not mssing something, isnt it? Also please use single quotes for the string. '<body class="' . $debug . '">' -
Steffen Kamper uploaded patch set 3 04/07/18, 10:37
-
Steffen Kamper uploaded patch set 4 04/07/18, 10:38
-
TYPO3com voted on patch set 3 V -1 04/07/18, 10:47 Completed build in 09m 28s on Sat, 7 Apr, 12:47 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22181
-
TYPO3com voted on patch set 4 V -1 04/07/18, 10:48 Completed build in 09m 36s on Sat, 7 Apr, 12:48 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22182
-
Oliver Klee commented on patch set 5 04/07/18, 11:10
Published edit on patch set 4. -
TYPO3com voted on patch set 5 V -1 04/07/18, 11:19 Completed build in 08m 26s on Sat, 7 Apr, 01:19 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22183
-
Daniel Goerz commented on patch set 5 04/07/18, 11:21
ModuleTemplate.php:301Again, what do we need the $context for? The CSS only cares for the debug class. -
Mathias Schreiber commented on patch set 5 V -1 CR -1 04/08/18, 14:15
_module_web_page.scss:391UnresolvedCan you use one of the available color variables here, please?_module_web_page.scss:396UnresolvedPlease do not use any classes prefixed with t3js- for styling purposes. These are only to be used for JS triggers. -
Steffen Kamper uploaded patch set 6 04/09/18, 11:08
-
TYPO3com voted on patch set 6 V -1 04/09/18, 11:16 Completed build in 07m 56s on Mon, 9 Apr, 01:16 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22219
-
Benni Mack abandoned the change 10/28/18, 10:38
abandoned for now, as there was no feedback in the last 6 months. Can be restored later.