Review main Merged

56611[TASK] Use symfony/finder to collect TCA

Andreas Kienast CR +2 V +2 Easy +20 −30 updated 05/11/18, 12:27

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Mathias Schreiber +1
    • Mathias Brodala +1
  • Verified V +2
    • Frank Nägler +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1824

  1. Andreas Kienast uploaded patch set 1 04/09/18, 07:09

  2. TYPO3com voted on patch set 1 V -1 04/09/18, 07:18 Completed build in 08m 33s on Mon, 9 Apr, 09:18 AM Test Summary: 9 of 31100 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22213

  3. Mathias Brodala commented on patch set 2 04/09/18, 07:33

    Published edit on patch set 1.
  4. Mathias Brodala commented on patch set 2 04/09/18, 07:34

    Used fresh Finder instance on every iteration to avoid unexpected side-effects.
  5. TYPO3com voted on patch set 2 V -1 04/09/18, 07:41 Completed build in 08m 07s on Mon, 9 Apr, 09:41 AM Test Summary: 9 of 31100 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22215

  6. Andreas Kienast commented on patch set 2 04/09/18, 09:16

    > Patch Set 2: > > Used fresh Finder instance on every iteration to avoid unexpected side-effects. What happens in the foreach() when \InvalidArgumentException is thrown? I think the foreach either fails or re-uses the previous, functional state. What do you think?
  7. Mathias Brodala commented on patch set 2 04/09/18, 09:25

    > > Patch Set 2: > > > > Used fresh Finder instance on every iteration to avoid unexpected > side-effects. > > What happens in the foreach() when \InvalidArgumentException is > thrown? I think the foreach either fails or re-uses the previous, > functional state. What do you think? I'm not sure I get what you mean. The change was mostly meant to decouple the two loops which both use a Finder. If an InvalidArgumentException is thrown, the loop immediately skips and the Finder object is never used.
  8. Andreas Kienast commented on patch set 2 04/09/18, 09:33

    > Patch Set 2: > I'm not sure I get what you mean. The change was mostly meant to decouple the two loops which both use a Finder. If an InvalidArgumentException is thrown, the loop immediately skips and the Finder object is never used. Yeah right. It's Monday, y'know...
  9. Andreas Kienast uploaded patch set 3 04/09/18, 09:35

  10. TYPO3com voted on patch set 3 V -1 04/09/18, 09:43 Completed build in 08m 04s on Mon, 9 Apr, 11:43 AM Test Summary: 7 of 31100 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22218

  11. Andreas Kienast rebased onto patch set 4 05/05/18, 15:14

  12. Andreas Kienast uploaded patch set 5 05/05/18, 15:18

  13. TYPO3com voted on patch set 4 V -1 05/05/18, 15:22 Completed build in 08m 32s on Sat, 5 May, 05:22 PM Test Summary: 7 of 31091 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23072

  14. TYPO3com voted on patch set 5 V +1 05/05/18, 15:26 Completed build in 08m 10s on Sat, 5 May, 05:26 PM Test Summary: 31154 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23073

  15. Frank Nägler voted on patch set 5 CR +1 05/09/18, 12:32

  16. Mathias Brodala commented on patch set 5 05/09/18, 12:42

    ExtensionManagementUtility.php:1671

    Can you store this in an additional variable to make the purpose clearer? The old code did this quite well.
  17. Andreas Kienast uploaded patch set 6 05/09/18, 12:59

  18. Mathias Brodala voted on patch set 6 CR +1 05/09/18, 13:06

  19. TYPO3com voted on patch set 6 V +1 05/09/18, 13:08 Completed build in 09m 08s on Wed, 9 May, 03:08 PM Test Summary: 12345 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23237

  20. Nicole Hummel commented on patch set 5 05/09/18, 13:11

    ExtensionManagementUtility.php:1671 Reply

    This seems to be quite breaking now, because we cannot assure the an array is returned here. I would opt to not remove the is_array check here
  21. Mathias Brodala commented on patch set 5 05/09/18, 13:14

    ExtensionManagementUtility.php:1671 Reply

    This was fixed in the following change already.
  22. Mathias Schreiber voted on patch set 6 V +1 CR +1 05/10/18, 09:42

  23. Frank Nägler voted on patch set 6 V +2 CR +2 05/11/18, 12:27

  24. Frank Nägler merged patch set 7 05/11/18, 12:27