Review TYPO3_8-7 Merged

56653[BUGFIX] Fix nightly CGL check

Anja Leichsenring CR +2 V +2 Easy +12 −12 updated 04/15/18, 11:07

Commit message

PHP-CS-Fixer introduced a notice about overridden config paths,
which causes the cgl check to fail.
See https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/2999

Review

  • Code review CR +2
    • Benni Mack +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Frans Saris +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1114

  1. Anja Leichsenring uploaded patch set 1 04/14/18, 10:57

  2. TYPO3com voted on patch set 1 V +1 04/14/18, 11:07 Completed build in 09m 44s on Sat, 14 Apr, 01:07 PM Test Summary: 58267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2260

  3. Anja Leichsenring uploaded patch set 2 04/14/18, 11:08

  4. TYPO3com voted on patch set 2 V +1 04/14/18, 11:18 Completed build in 10m 08s on Sat, 14 Apr, 01:18 PM Test Summary: 58267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2261

  5. Anja Leichsenring commented on patch set 2 V -1 04/14/18, 11:33

    nope, not this way. Still on it.
  6. Anja Leichsenring uploaded patch set 3 04/14/18, 11:57

  7. Anja Leichsenring commented on patch set 3 04/14/18, 11:58

    the same has been done for master: https://review.typo3.org/c/53638/ the change also includes some cgl fixes now, which made the run fail before.
  8. TYPO3com voted on patch set 3 V +1 04/14/18, 12:06 Completed build in 08m 50s on Sat, 14 Apr, 02:06 PM Test Summary: 58267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2262

  9. Wouter Wolters voted on patch set 3 V +1 CR +1 04/14/18, 12:08

  10. Anja Leichsenring commented on patch set 3 04/14/18, 12:26

    qed: https://bamboo.typo3.com/browse/CORE-GTN87-299 manual run of nightly plan with this branch and patchset.
  11. Oliver Klee voted on patch set 3 CR +1 04/14/18, 17:18

  12. Frans Saris commented on patch set 3 CR +1 04/15/18, 09:34

    Bamboo is happy so this can be merged?
  13. Benni Mack voted on patch set 3 V +2 CR +2 04/15/18, 11:07

  14. Benni Mack merged patch set 4 04/15/18, 11:07