Review main Merged

56664[TASK] Move rootPage resolving into PSR-15 middleware

Benni Mack CR +2 V +2 Normal +150 −35 updated 04/15/18, 10:17

Commit message

The functionality to resolve the "domain start page" - the page ID
where a sys_domain record is found, is moved from TSFE/sys_page
into the SiteResolver middleware, making the domain start page value
available at an earlier point of a request.

Change of behaviours:
- TSFE->domainStartPage is now filled earlier than before
- TSFE->domainStartPage is now filled regardless of access checks of the
permissions of that page record, as the check is done later-on again anyways.

For the sake of completeness:
If a site is configured, this code is not executed anymore, as the site contains
the rootpage ID already anyways.

The method "TypoScriptFrontendController->findDomainRecord"
is removed, as it was marked as private and should have not been
used outside TYPO3 Core.

The method "PageRepository->getDomainStartPage" is marked
as deprecated as it is not called anymore.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5