Review main Abandoned

56668[WIP][TASK] Add command shortcuts for executing tests via docker

Sybille Peters CR 0 V 0 Hard +269 −0 updated 04/20/18, 09:59

Commit message

This review is being used to work on a WIP, but it should be abandoned
in favor of review 54959.

The current version is still very much WIP. Once this is in a more
mature state, we can move our results to the other review, if this
makes sense. (This way we don't notify the reviewers of the other
patch on every change. We give them the final result).

Currently there are several issues

- Which is the best way to go to make it portable?

- This solution requires docker. Docker is currently not in the tool
  buildchain. So we are using something without a requirement
  we can't resolve with composer. And installing docker should not
  really be a composer requirement. We are mixing PHP dependencies
  and scripts with a containerization solution. Is this really the
  way to go?

- This solution has to be maintained. It pulls resources away from
  TYPO3.

What is nice about this solution:

- You will automatically use the docker container for the correct
  PHP version depending on which branch you are working in

- make things simpler for developers. They have the commands
  which correspond to the TYPO3 version. If the files for unit
  tests are changed in the future, the commands will still work

This is what the patch originally intended to do:

- Add files with db credentials. This can be used when running
  docker, e.g. docker run --env-file (all credentials are in
  Build/bamboo/src/main/java/core/AbstractCoreSpec.java)

- Add scripts to execute unit / functional tests to composer.json

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7