5691[BUGFIX] md5.js fails with non-ascii-characters
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
-
Verified V +2
- Oliver Hader +2
Issues 1
Files 1
Review log 11
-
Stefan Neufeind commented on patch set 1 01/18/12, 08:52
Verified; Looks good to me, but someone else must approve The original one only had a small allowed charset. With this one (and Unicode) other characters are possible as well. -
Stefan Neufeind commented on patch set 1 01/18/12, 08:52
only a backport. would be great if somebody could have a final look and merge this. -
Markus Klein commented on patch set 1 01/18/12, 08:52
Two month have passed since 4.6 was submitted. Time for this one? -
Markus Klein commented on patch set 2 01/18/12, 08:52
Two month have passed since 4.6 was submitted. Time for this one? -
Oliver Hader uploaded patch set 2 01/18/12, 08:52
-
Oliver Hader commented on patch set 2 01/18/12, 08:52
Verified; Looks good to me, but someone else must approve Automated rebasing to TYPO3_4-5 - Please consider updating your reviews V:1, R:1 as a summary of previous scores (limited to [-1;+1]) V:1, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> V:2, R:2 from Xavier Perseguers <xavier@typo3.org> -
Oliver Hader commented on patch set 2 V 0 01/18/12, 08:52
by team member; Looks good to me, approved Since it has been in TYPO3 4.6 already, this serves as "testing"... +2 -
Xavier Perseguers commented on patch set 1 01/18/12, 08:52
Please hold on this patch even if it's a backport, we should first make sure there is no side-effect in 4.6 for a while before backporting it. -
Xavier Perseguers commented on patch set 1 V 0 01/18/12, 08:52
by team member; Looks good to me, approved Backported from master -
Mr. Jenkins commented on patch set 1 01/18/12, 08:52
Build Successful https://ci.typo3.org/job/typo3-v4-core_4-5-gerrit/372/ : SUCCESS -
Oliver Hader merged patch set 2 01/18/12, 08:52