Review main Merged

56916[TASK] Deprecate various TSFE methods

Benni Mack CR +2 V +2 Normal +192 −24 updated 05/11/18, 09:34

Commit message

A lot of functionality has been migrated from
TypoScriptFrontendController into middlewares
- functionality that has now no direct influence
in the so-called controller of the frontend (TSFE)
anymore. The respective methods are never called
anymore from TYPO3 Core, and extensions that
bootstrap their own frontend should ensure that
the respective Middlewares are boot up and called,
e.g. via custom stacks or just by setting up
the "frontend" middleware stack.

The following methods are now deprecated:
- connectToDB()
- checkAlternativeIdMethods()
- initializeBackendUser()
- handleDataSubmission()
- setCSS()
- convPOSTCharset()

Additionally, there are some methods in TSFE
which have been marked as "internal" but had the
PHP visibility "public", which were now
migrated to "protected".

- getPageAndRootline()
- checkRootlineForIncludeSection()
- setSysPageWhereClause()
- checkAndSetAlias()
- getHash()
- getLockHash()
- setUrlIdToken()

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6