Review TYPO3_4-4 Merged

5692[BUGFIX] md5.js fails with non-ascii-characters

Xavier Perseguers CR +2 V +2 Hard +192 −364 updated 06/03/13, 20:49

Commit message

Current implementation of md5.js only considers a very
limited range of characters.
The implementation from webtoolkit.info uses correct
unicode-representation.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Oliver Hader +2
    • Stefan Neufeind +1
  • Verified V +2
    • Xavier Perseguers +2
    • Oliver Hader +2
    • Stefan Neufeind +1

Issues 1

Files 1

Review log 7

  1. Stefan Neufeind commented on patch set 1 01/18/12, 08:54

    Verified; Looks good to me, but someone else must approve The original one only had a small allowed charset. With this one (and Unicode) other characters are possible as well.
  2. Stefan Neufeind commented on patch set 1 01/18/12, 08:54

    only a backport. would be great if somebody could have a final look and merge this.
  3. Markus Klein commented on patch set 1 01/18/12, 08:54

    Two month have passed since 4.6 was submitted. Time for this one?
  4. Oliver Hader commented on patch set 1 V 0 01/18/12, 08:54

    by team member; Looks good to me, approved
  5. Xavier Perseguers commented on patch set 1 01/18/12, 08:54

    Please hold on this patch even if it's a backport, we should first make sure there is no side-effect in 4.6 for a while before backporting it.
  6. Xavier Perseguers commented on patch set 1 V 0 01/18/12, 08:54

    by team member; Looks good to me, approved Backported from master
  7. Oliver Hader merged patch set 1 01/18/12, 08:54