Review main Merged

56943[BUGFIX] Add css for marking broken links in rte_ckeditor

Sybille Peters CR +2 V +2 Easy +46 −0 updated 05/15/18, 11:02

Commit message

The styling for broken page links that was added in
RteHtmlParser::markBrokenLinks is by default removed by ckeditor
so this functionality is no longer available by default.

Page links which link to a non-existing page currently already
get the additional attribute a[data-rte-error]. This patch adds
CSS to visually style broken links with a red border and yellow
background. This is the same styling that was previously used.

This is done by adding the plugin showbrokenlinks.

The style is still added in markBrokenLinks. These attributes
will be removed by ckeditor by default. However, the functionality
is kept to function as fallback.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3