Review main Merged

56947[FEATURE] Mark broken external links in RTE

Sybille Peters CR +2 V +2 Hard +312 −12 updated 11/07/19, 10:21

Commit message

Before this change, only broken page links were marked
in RTE.

In general: If a broken link is to be marked in the RTE, extra
markup is automatically added by the transform db -> RTE function.
This will cause the broken link to stand out (yellow background
with red border).

With this patch the behaviour was extended to marking "external"
links as well. External links are checked by linkvalidator, using
existing linkvalidator table of broken links

In order to enable the external link checking, a new PSR-14 Event
has been defined. This makes the behaviour consistent and
configurable.

The link checking can also be done by other external extensions
using the introduced Event.

Performance considerations:

If installed, linkvalidator is used to check external links.
The implementation does not do the external link checking on
the fly by submitting a HTTP request to external webservers,
but uses the information already gathered in linkvalidator
tx_linkvalidator_link table instead. Thus, one DB query is
necessary for each link that is checked.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 8