Review main Merged

56955[TASK] Deprecate BackendUtility::getPidForModTSconfig()

Christian Kuhn CR +2 V +2 Easy +43 −1 updated 05/14/18, 06:09

Commit message

Removing cruft from BackendUtility is always fun. This time an
internal marked one-liner that is used only once bites the dust.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Anja Leichsenring +1
  • Verified V +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 56

  1. Christian Kuhn uploaded patch set 1 05/13/18, 19:20

  2. TYPO3com voted on patch set 1 V +1 05/13/18, 19:29 Completed build in 08m 40s on Sun, 13 May, 09:29 PM Test Summary: 31153 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23450

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 05/13/18, 19:32

  4. Wouter Wolters voted on patch set 1 V +2 CR +2 05/13/18, 20:26

  5. Wouter Wolters merged patch set 2 05/13/18, 20:26

  6. Stefan Neufeind voted on patch set 2 V +1 CR +1 05/14/18, 06:09