Review main Merged Breaking

56976[!!!][TASK] Make all enumerations final

Mathias Brodala CR +2 V +2 Hard +117 −147 updated 06/01/18, 12:57

Commit message

Code which uses enumerations expects a known set of values, adding
more values by extending these classes leads to undefined behavior.

Since it is now impossible to create a mock of an enumeration also
drop a few Enumeration tests and stick to testing of the public API.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 16