Review main Abandoned

56980[WIP][FEATURE] POC for low level assertions

Ralf Zimmermann CR 0 V 0 Expert +1116 −0 updated 09/04/18, 06:37

Commit message

$result = Assert::that(5)->is(NumericComparison::greaterThan(4));

$result = Assert::thatAllOf([1,2,3])
            ->is(NumericComparison::greaterThan(4));

$result = Assert::thatOneOf([1,2,3])
            ->is(NumericComparison::greaterThan(4));

$result = Assert::that(5)->isNot(NumericComparison::greaterThan(4));

$result = Assert::that(5)->is(LogicComparison::Or(
    NumericComparison::equals(4),
    NumericComparison::between(5, 9)
));

Review

  • Code review CR 0
  • Verified V 0

Files 7

Review log 68

  1. Ralf Zimmermann uploaded patch set 1 05/16/18, 16:40

  2. TYPO3com voted on patch set 1 V -1 05/16/18, 16:40 Completed build in 05s on Wed, 16 May, 06:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23565

  3. Ralf Zimmermann uploaded patch set 2 05/16/18, 16:45

  4. TYPO3com voted on patch set 2 V +1 05/16/18, 16:52 Completed build in 07m 01s on Wed, 16 May, 06:52 PM Test Summary: 31183 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23566

  5. Mathias Brodala commented on patch set 2 05/17/18, 07:38

    How about using one of the most popular packages on Packagist for this? E.g. https://packagist.org/packages/webmozart/assert https://packagist.org/packages/beberlei/assert
  6. Helmut Hummel commented on patch set 2 05/17/18, 09:32

  7. Helmut Hummel wrote 07/23/18, 18:15

    Removed reviewer Helmut Hummel.
  8. Ralf Zimmermann abandoned the change 09/04/18, 06:37