Review main Abandoned

57000[BUGFIX] Compare identifiers instead of instances

Susi Moog CR 0 V 0 Easy +1 −1 updated 05/18/18, 09:46

Commit message

To re-allow deleting files in the file list module
a loop condition has been changed to check for
equality of folders by comparing its combined
identifiers instead of strictly comparing folder
instances (which fails as they are different instances
of the same folder representation).

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 3

  1. Susi Moog uploaded patch set 1 05/18/18, 09:41

  2. Wouter Wolters voted on patch set 1 CR +1 05/18/18, 09:43

  3. Susi Moog abandoned the change 05/18/18, 09:46