Review main Merged

57046[BUGFIX] Allow writing temp files in composer mode

Benni Mack CR +2 V +2 Normal +146 −28 updated 05/29/18, 23:19

Commit message

The new Environment API allows to set the project path
outside of the web root, also moving typo3temp/var/
to env:PROJECT_PATH + var/.

However, the main method GeneralUtility::writeFileToTypo3tempDir()
which is used for adding online media, charset conversion etc.
is not adapted to allow files outside of typo3temp/
which needs adaptions wo also check for PROJECT_PATH + var/
in addition.

Some generic tests were added to ensure the existing functionality
still works.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2