Review main Merged

57047[TASK] Deprecate PageRepository->versioningPreview

Benni Mack CR +2 V +2 Normal +99 −101 updated 10/04/18, 20:26

Commit message

PageRepository has two public properties regarding
fetching records for versioned records:
- versioningPreview (bool)
- versioningWorkspaceId (int)

In order to allow previews of versions, a workspace ID
has to be set - otherwise it fetches live records.

Basically things like: $versioningPreview=false,
$versioningWorkspaceId=3 will make things more confusing.

Instead, versioningPreview is not in use anymore,
and PageRepository solely relies on the parameter
of the workspaceId set.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 13