Review main Merged

57056[TASK] Deprecate GeneralUtility::arrayToLogString()

Benni Mack CR +2 V +2 Normal +72 −6 updated 05/28/18, 11:34

Commit message

The method arrayToLogString() within GeneralUtility is deprecated in favor of using
own implementations, based on PSR-3.

Still, the one place where this method was in use - ListSysLogCommand -
moved the logic into its own protected method.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Markus Klein +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 911

  1. Benni Mack uploaded patch set 1 05/27/18, 13:14

  2. TYPO3com voted on patch set 1 V +1 05/27/18, 13:22 Completed build in 08m 13s on Sun, 27 May, 03:22 PM Test Summary: 31095 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23793

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 05/27/18, 15:24

  4. Markus Klein commented on patch set 1 05/27/18, 17:49

    ListSysLogCommand.php:126

    should we add :string here?
  5. Georg Ringer voted on patch set 1 V +1 CR +1 05/28/18, 03:49

  6. Benni Mack commented on patch set 2 05/28/18, 10:22

    Published edit on patch set 1.
  7. TYPO3com voted on patch set 2 V +1 05/28/18, 10:29 Completed build in 07m 09s on Mon, 28 May, 12:29 PM Test Summary: 31110 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23807

  8. Markus Klein commented on patch set 2 V +1 CR +1 05/28/18, 11:22

    tested that the command still works
  9. Wouter Wolters voted on patch set 2 V +1 CR +1 05/28/18, 11:25

  10. Georg Ringer voted on patch set 2 V +2 CR +2 05/28/18, 11:34

  11. Georg Ringer merged patch set 3 05/28/18, 11:34