Review main Merged

57075[TASK] Deprecate 3rd argument in PageRepository->getRootLine()

Benni Mack CR +2 V +2 Normal +60 −7 updated 05/29/18, 21:38

Commit message

The third argument about catching errors can be achieved by building a try/catch
block around the method.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Mathias Brodala +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 811

  1. Benni Mack uploaded patch set 1 05/28/18, 20:10

  2. TYPO3com voted on patch set 1 V +1 05/28/18, 20:18 Completed build in 08m 00s on Mon, 28 May, 10:18 PM Test Summary: 31122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23848

  3. Wouter Wolters voted on patch set 1 CR +1 05/28/18, 20:19

  4. Mathias Brodala commented on patch set 2 05/29/18, 07:19

    Published edit on patch set 1.
  5. Mathias Brodala voted on patch set 2 CR +1 05/29/18, 07:19

  6. TYPO3com voted on patch set 2 V -1 05/29/18, 07:27 Completed build in 08m 26s on Tue, 29 May, 09:27 AM Test Summary: 1 of 31370 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23858

  7. TYPO3com voted on patch set 2 V +1 05/29/18, 07:32 Completed build in 21m 16s on Tue, 29 May, 09:32 AM Test Summary: 31122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23858

  8. Wouter Wolters voted on patch set 2 CR +1 05/29/18, 20:56

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 05/29/18, 21:32

  10. Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 05/29/18, 21:38

  11. Tymoteusz Motylewski merged patch set 3 05/29/18, 21:38