Review main Merged

57090[TASK] CharsetConverter: Remove Case Folding

Benni Mack CR +2 V +2 Hard +16 −417 updated 05/30/18, 17:37

Commit message

Special Case Folding within CharsetConverter is not used anymore, and can be removed.

The public property $caseFolding used as runtime cache is removed, as it was never possible
to fill it either to have it accessed from the outside.

The SpecialCasing.txt file has no meaning anymore and can be removed.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Wouter Wolters +2
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 05/30/18, 12:43

  2. TYPO3com voted on patch set 1 V +1 05/30/18, 12:51 Completed build in 08m 02s on Wed, 30 May, 02:51 PM Test Summary: 31167 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23904

  3. Wouter Wolters voted on patch set 1 CR +1 05/30/18, 12:59

  4. Tymoteusz Motylewski voted on patch set 1 V +1 CR +1 05/30/18, 17:31

  5. Wouter Wolters voted on patch set 1 V +2 CR +2 05/30/18, 17:37

  6. Wouter Wolters merged patch set 2 05/30/18, 17:37