Review main Merged

57094[TASK] Deprecate various functionality in CharsetConverter

Benni Mack CR +2 V +2 Normal +179 −10 updated 05/30/18, 19:35

Commit message

Due to native support and a polyfill for mb_string(), lot of functionality of
CharsetConverter was simplified throughout TYPO3 in the last release
to ensure faster charset conversion.

Many methods and properties within CharsetConverter can be deprecated
now:
- CharsetConverter->synonyms
- CharsetConverter->parse_charset()
- Fourth parameter of CharsetConverter->conv()
- CharsetConverter->convArray()
- CharsetConverter->utf8_to_entities()
- CharsetConverter->entities_to_utf8()
- CharsetConverter->crop()
- CharsetConverter->convCaseFirst()
- CharsetConverter->utf8_char2byte_pos()

Additionally the following public properties have been changed to have a "protected"
visibility, as this only reflects internal state:
- CharsetConverter->noCharByteVal
- CharsetConverter->parsedCharsets
- CharsetConverter->toASCII
- CharsetConverter->twoByteSets
- CharsetConverter->eucBasedSets

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 57

  1. Benni Mack uploaded patch set 1 05/30/18, 17:59

  2. TYPO3com voted on patch set 1 V +1 05/30/18, 18:08 Completed build in 08m 32s on Wed, 30 May, 08:08 PM Test Summary: 31149 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23909

  3. Wouter Wolters updated the commit message in patch set 2 05/30/18, 18:09

  4. TYPO3com voted on patch set 2 V +1 05/30/18, 18:17 Completed build in 08m 28s on Wed, 30 May, 08:17 PM Test Summary: 31149 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23911

  5. Wouter Wolters commented on patch set 2 V +1 CR +1 05/30/18, 18:20

    CharsetConverter.php:276

    this will trigger a second deprecation warning by default if this method is used.
  6. Christian Kuhn commented on patch set 2 V +2 CR +2 05/30/18, 19:35

    CharsetConverter.php:276 Reply

    well, not easy to fix - maybe just accept this.
  7. Christian Kuhn merged patch set 3 05/30/18, 19:35