57094[TASK] Deprecate various functionality in CharsetConverter
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Charset/CharsetConverter.php2+46 −8
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85122-FunctionalityInCharsetConverter.rstnew+52 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+49 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyProtectedMatcher.php+27 −2
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+5 −0
Review log 57
-
Benni Mack uploaded patch set 1 05/30/18, 17:59
-
TYPO3com voted on patch set 1 V +1 05/30/18, 18:08 Completed build in 08m 32s on Wed, 30 May, 08:08 PM Test Summary: 31149 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23909
-
Wouter Wolters updated the commit message in patch set 2 05/30/18, 18:09
-
TYPO3com voted on patch set 2 V +1 05/30/18, 18:17 Completed build in 08m 28s on Wed, 30 May, 08:17 PM Test Summary: 31149 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23911
-
Wouter Wolters commented on patch set 2 V +1 CR +1 05/30/18, 18:20
-
Christian Kuhn commented on patch set 2 V +2 CR +2 05/30/18, 19:35
CharsetConverter.php:276Replywell, not easy to fix - maybe just accept this. -
Christian Kuhn merged patch set 3 05/30/18, 19:35
CharsetConverter.php:276