Review main Merged

57097[TASK] Deprecate usages of CharsetConverter in core

Benni Mack CR +2 V +2 Normal +93 −19 updated 05/30/18, 22:11

Commit message

CharsetConverter is still instantiated in some places and not needed at all times.

The following places have CharsetConverter completely removed (as internal property):
- PageRenderer
- SearchController
- Indexer

The AbstractHierarchicalFilesystemDriver's shorthand method getCharsetConversion()
has been deprecated, as drivers should instantiate the CharsetConversion themself.

Indexed Search's Lexer has a public property "csObj" which has been switched to
protected, where a deprecation message will be thrown.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 9