Review main Merged

57099[BUGFIX] Correctly define allowedSubProperties of TwitterCardMetaTagManager

Richard Haeser CR +2 V +2 Normal +227 −15 updated 06/02/18, 21:50

Commit message

The properties within the allowedSubProperties have to be arrays
because the AbstractMetaTagManager checks if the property as a key
exists in the allowSubProperties.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Anja Leichsenring +1
    • Mona Muzaffar +1
  • Verified V +2
    • Jigal van Hemert +2
    • Anja Leichsenring +1
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1826

Show 1 earlier messages
  1. Richard Haeser uploaded patch set 1 05/30/18, 20:56

  1. Tymoteusz Motylewski commented on patch set 1 05/30/18, 21:03

    how can this be tested?
  2. TYPO3com voted on patch set 1 V +1 05/30/18, 21:08 Completed build in 11m 34s on Wed, 30 May, 11:08 PM Test Summary: 31147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23928

  3. Richard Haeser commented on patch set 1 05/30/18, 21:21

    It can be tested by a little bit of PHP in a frontend context (for example an Extbase controller action): $metaTagManagerRegistry = \TYPO3\CMS\Core\MetaTag\MetaTagManagerRegistry::getInstance(); $manager = $metaTagManagerRegistry->getManagerForProperty('twitter:image'); $manager->addProperty( 'twitter:image', 'https://example.com/image.jpg';, ['alt' => 'Test alt'] );
  4. Richard Haeser updated the commit message in patch set 2 05/30/18, 21:34

  5. TYPO3com voted on patch set 2 V +1 05/30/18, 21:41 Completed build in 07m 06s on Wed, 30 May, 11:41 PM Test Summary: 31147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23933

  6. Tymoteusz Motylewski commented on patch set 2 CR -1 05/31/18, 08:20

    Thanks Richard. This should be covered with unit tests, similar to other metaTag classes.
  7. Riny van Tiggelen voted on patch set 2 CR +1 05/31/18, 08:20

  8. Richard Haeser uploaded patch set 3 06/01/18, 12:57

  9. Andreas Kienast uploaded patch set 4 06/01/18, 13:01

  10. TYPO3com voted on patch set 3 V -1 06/01/18, 13:05 Completed build in 08m 09s on Fri, 1 Jun, 03:05 PM Test Summary: 3031 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23983

  11. TYPO3com voted on patch set 4 V +1 06/01/18, 13:09 Completed build in 07m 54s on Fri, 1 Jun, 03:09 PM Test Summary: 31141 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23985

  12. Anja Leichsenring uploaded patch set 5 06/01/18, 13:13

  13. TYPO3com voted on patch set 5 V +1 06/01/18, 13:20 Completed build in 07m 00s on Fri, 1 Jun, 03:20 PM Test Summary: 31141 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23987

  14. Anja Leichsenring commented on patch set 5 V -1 06/01/18, 13:26

    waiting for Richard to repush
  15. Richard Haeser uploaded patch set 6 06/01/18, 13:27

  16. TYPO3com voted on patch set 6 V -1 06/01/18, 13:27 Completed build in 09s on Fri, 1 Jun, 03:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23989

  17. Richard Haeser uploaded patch set 7 06/01/18, 13:29

  18. Anja Leichsenring commented on patch set 7 06/01/18, 13:31

    TwitterCardMetaTagManagerTest.php:45 Unresolved

    missing type hints on input parameters
  19. TYPO3com voted on patch set 7 V +1 06/01/18, 13:38 Completed build in 09m 06s on Fri, 1 Jun, 03:38 PM Test Summary: 31144 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23990

  20. Richard Haeser uploaded patch set 8 06/01/18, 13:52

  21. TYPO3com voted on patch set 8 V +1 06/01/18, 13:59 Completed build in 07m 05s on Fri, 1 Jun, 03:59 PM Test Summary: 31144 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23994

  22. Mona Muzaffar voted on patch set 8 V +1 CR +1 06/01/18, 14:51

  23. Anja Leichsenring voted on patch set 8 V +1 CR +1 06/01/18, 14:51

  24. Jigal van Hemert voted on patch set 8 V +2 CR +2 06/02/18, 21:50

  25. Jigal van Hemert merged patch set 9 06/02/18, 21:50