57099[BUGFIX] Correctly define allowedSubProperties of TwitterCardMetaTagManager
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Anja Leichsenring +1
- Mona Muzaffar +1
-
Verified V +2
- Jigal van Hemert +2
- Anja Leichsenring +1
- Mona Muzaffar +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1826
Show 1 earlier messages
-
Richard Haeser uploaded patch set 1 05/30/18, 20:56
-
Tymoteusz Motylewski commented on patch set 1 05/30/18, 21:03
how can this be tested? -
TYPO3com voted on patch set 1 V +1 05/30/18, 21:08 Completed build in 11m 34s on Wed, 30 May, 11:08 PM Test Summary: 31147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23928
-
Richard Haeser commented on patch set 1 05/30/18, 21:21
It can be tested by a little bit of PHP in a frontend context (for example an Extbase controller action): $metaTagManagerRegistry = \TYPO3\CMS\Core\MetaTag\MetaTagManagerRegistry::getInstance(); $manager = $metaTagManagerRegistry->getManagerForProperty('twitter:image'); $manager->addProperty( 'twitter:image', 'https://example.com/image.jpg';, ['alt' => 'Test alt'] ); -
Richard Haeser updated the commit message in patch set 2 05/30/18, 21:34
-
TYPO3com voted on patch set 2 V +1 05/30/18, 21:41 Completed build in 07m 06s on Wed, 30 May, 11:41 PM Test Summary: 31147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23933
-
Tymoteusz Motylewski commented on patch set 2 CR -1 05/31/18, 08:20
Thanks Richard. This should be covered with unit tests, similar to other metaTag classes. -
Riny van Tiggelen voted on patch set 2 CR +1 05/31/18, 08:20
-
Richard Haeser uploaded patch set 3 06/01/18, 12:57
-
Andreas Kienast uploaded patch set 4 06/01/18, 13:01
-
TYPO3com voted on patch set 3 V -1 06/01/18, 13:05 Completed build in 08m 09s on Fri, 1 Jun, 03:05 PM Test Summary: 3031 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23983
-
TYPO3com voted on patch set 4 V +1 06/01/18, 13:09 Completed build in 07m 54s on Fri, 1 Jun, 03:09 PM Test Summary: 31141 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23985
-
Anja Leichsenring uploaded patch set 5 06/01/18, 13:13
-
TYPO3com voted on patch set 5 V +1 06/01/18, 13:20 Completed build in 07m 00s on Fri, 1 Jun, 03:20 PM Test Summary: 31141 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23987
-
Anja Leichsenring commented on patch set 5 V -1 06/01/18, 13:26
waiting for Richard to repush -
Richard Haeser uploaded patch set 6 06/01/18, 13:27
-
TYPO3com voted on patch set 6 V -1 06/01/18, 13:27 Completed build in 09s on Fri, 1 Jun, 03:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23989
-
Richard Haeser uploaded patch set 7 06/01/18, 13:29
-
Anja Leichsenring commented on patch set 7 06/01/18, 13:31
TwitterCardMetaTagManagerTest.php:45Unresolvedmissing type hints on input parameters -
TYPO3com voted on patch set 7 V +1 06/01/18, 13:38 Completed build in 09m 06s on Fri, 1 Jun, 03:38 PM Test Summary: 31144 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23990
-
Richard Haeser uploaded patch set 8 06/01/18, 13:52
-
TYPO3com voted on patch set 8 V +1 06/01/18, 13:59 Completed build in 07m 05s on Fri, 1 Jun, 03:59 PM Test Summary: 31144 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23994
-
Mona Muzaffar voted on patch set 8 V +1 CR +1 06/01/18, 14:51
-
Anja Leichsenring voted on patch set 8 V +1 CR +1 06/01/18, 14:51
-
Jigal van Hemert voted on patch set 8 V +2 CR +2 06/02/18, 21:50
-
Jigal van Hemert merged patch set 9 06/02/18, 21:50