Review main Merged

57106[TASK] Move TSFE->getPageShortcut to PageRepository

Benni Mack CR +2 V +2 Normal +126 −62 updated 06/01/18, 12:23

Commit message

The method `getPageShortcut()` which is marked as private is moved to
PageRepository, as it only requires logic and methods from
PageRepository.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Mathias Brodala +1
  • Verified V +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1519

  1. Benni Mack uploaded patch set 1 05/31/18, 18:40

  2. TYPO3com voted on patch set 1 V +1 05/31/18, 18:47 Completed build in 07m 07s on Thu, 31 May, 08:47 PM Test Summary: 31147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23957

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 05/31/18, 19:22

  4. Wouter Wolters voted on patch set 1 CR +1 05/31/18, 19:56

  5. Wouter Wolters commented on patch set 1 CR -1 05/31/18, 20:15

    PageRepository.php:658

    should be changed too

    PageRepository.php:715

    should be changed too
  6. Anja Leichsenring uploaded patch set 2 06/01/18, 10:38

  7. Anja Leichsenring uploaded patch set 3 06/01/18, 10:40

  8. Anja Leichsenring voted on patch set 3 V +1 CR +1 06/01/18, 10:40

  9. Mathias Brodala commented on patch set 3 06/01/18, 10:46

    Deprecation-85130-TSFE-getPageShortcutMovedToPageRepository.rst:12

    Should be "::"

    Deprecation-85130-TSFE-getPageShortcutMovedToPageRepository.rst:13

    Same here.

    Deprecation-85130-TSFE-getPageShortcutMovedToPageRepository.rst:32

    This should at least be $GLOBALS['TSFE']->... And a PHP syntax highlight should be added too. :-)

    TypoScriptFrontendController.php:1536

    This should be TypoScriptFrontendController::getPageShortcut() instead.

    PageRepository.php:902

    Can we use this change to introduce more speaking argument names here?
  10. TYPO3com voted on patch set 2 V +1 06/01/18, 10:46 Completed build in 07m 39s on Fri, 1 Jun, 12:46 PM Test Summary: 31147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23971

  11. TYPO3com voted on patch set 3 V +1 06/01/18, 10:47 Completed build in 07m 29s on Fri, 1 Jun, 12:47 PM Test Summary: 31147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23972

  12. Anja Leichsenring uploaded patch set 4 06/01/18, 11:07

  13. Mathias Brodala voted on patch set 4 CR +1 06/01/18, 11:10

  14. Wouter Wolters voted on patch set 4 V +1 CR +1 06/01/18, 11:13

  15. TYPO3com voted on patch set 4 V +1 06/01/18, 11:14 Completed build in 06m 54s on Fri, 1 Jun, 01:14 PM Test Summary: 31147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23975

  16. Anja Leichsenring voted on patch set 4 V +1 CR +1 06/01/18, 11:55

  17. Andreas Kienast voted on patch set 4 CR +2 06/01/18, 12:18

  18. Andreas Kienast voted on patch set 4 V +2 06/01/18, 12:23

  19. Andreas Kienast merged patch set 5 06/01/18, 12:23