Review main Abandoned

5711[BUGFIX] Make it possible to use ?edit=<PID> again

Kay Strobach CR 0 V 0 Easy +27 −9 updated 05/03/14, 08:43

Commit message

This fix increases the timeframe before the system tries to load
the edit form of a given pid.

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 39

Show 14 earlier messages
  1. Xavier Perseguers uploaded patch set 2 05/27/13, 17:19

  2. Xavier Perseguers commented on patch set 2 05/27/13, 17:19

    Verified; I would prefer that you didn't submit this Fixed a few CGL issues Tested. Yes it works however: - selected page in page tree is not synchronized - edit form appears only after about 5 sec (guess: the value you put in the patch) and until then, "nothing" seems to be running, pending, no loading mask, nothing. I don't like that
  3. Kay Strobach commented on patch set 2 05/27/13, 17:19

    selection just works with knowing the pagepath (expand path and select). http://forge.typo3.org/issues/30773 Time is based on my local setup - i can mask the whole backend if you want, until the form is loaded
  4. Xavier Perseguers commented on patch set 3 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  5. Kay Strobach commented on patch set 3 05/27/13, 17:19

    use very short interval to try to load the module now.
  6. Kay Strobach uploaded patch set 3 05/27/13, 17:19

  7. Stefan Neufeind commented on patch set 6 05/27/13, 17:19

    (1 inline comment)
    and 4.8

    Reply

    6.0 meanwhile
  8. Stefan Neufeind commented on patch set 6 05/27/13, 17:19

    (1 inline comment) Somebody please have a look.
  9. Markus Klein uploaded patch set 6 05/27/13, 17:19

  10. Markus Klein commented on patch set 6 05/27/13, 17:19

    Rebased for 4.7. Commit message title shortened.
  11. Markus Klein uploaded patch set 7 05/27/13, 17:19

  12. Markus Klein commented on patch set 7 05/27/13, 17:19

    Rebased for master
  13. Markus Klein uploaded patch set 8 05/27/13, 17:19

  14. Markus Klein commented on patch set 8 05/27/13, 17:19

    Namespace rebase
  1. Markus Klein uploaded patch set 9 05/27/13, 17:19

  2. Markus Klein commented on patch set 9 05/27/13, 17:19

    Rebased for 6.1
  3. Oliver Hader commented on patch set 5 05/27/13, 17:19

    Rebasing to master V:0, R:0
  4. Oliver Hader uploaded patch set 5 05/27/13, 17:19

  5. Kay Strobach commented on patch set 4 05/27/13, 17:19

    the time until page edit is still very long, but i found no way to suppress the reload forced by the initalized pagetree ... so it takes nearly 13 secs from localhost :(
  6. Kay Strobach uploaded patch set 4 05/27/13, 17:19

  7. Jigal van Hemert commented on patch set 3 05/27/13, 17:19

    Fails Doesn't open the edit form (please beware that Templavoila provides a replacement for the edit form!) If it will be fixed in a different change, please abandon this one or limit this one to fixing the timeframe only.
  8. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  9. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  10. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  11. Mr. Jenkins commented on patch set 4 05/27/13, 17:19

  12. Mr. Jenkins commented on patch set 5 05/27/13, 17:19

  13. Mr. Jenkins commented on patch set 6 05/27/13, 17:19

  14. Mr. Jenkins commented on patch set 7 05/27/13, 17:19

  15. Mr. Jenkins commented on patch set 8 05/27/13, 17:19

  16. Mr. Jenkins commented on patch set 9 05/27/13, 17:19

  17. Markus Klein uploaded patch set 10 09/26/13, 23:32

  18. Mr. Jenkins commented on patch set 10 09/27/13, 00:18

  19. Markus Klein rebased onto patch set 10 01/16/14, 22:03

  20. Markus Klein updated the commit message in patch set 11 01/16/14, 22:05

  21. Markus Klein commented on patch set 12 01/16/14, 22:07

    backend.js:165

    is this a debugging thing?
  22. Mr. Jenkins commented on patch set 11 01/16/14, 22:18

  23. Stefan Neufeind commented on patch set 12 V -1 01/16/14, 22:19

    backend.js:165 Reply

    Yes, nothing besides debugging. We should remove that. Nice catch.
  24. Mr. Jenkins commented on patch set 12 01/16/14, 22:26

  25. Kay Strobach abandoned the change 05/03/14, 08:43